[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uses horizontal skylines in accidental placement (issue 6489086)
From: |
k-ohara5a5a |
Subject: |
Re: Uses horizontal skylines in accidental placement (issue 6489086) |
Date: |
Fri, 28 Sep 2012 06:56:36 +0000 |
http://codereview.appspot.com/6489086/diff/11/lily/accidental-placement.cc
File lily/accidental-placement.cc (right):
http://codereview.appspot.com/6489086/diff/11/lily/accidental-placement.cc#newcode377
lily/accidental-placement.cc:377: Real offset =
-ape->horizontal_skylines_[RIGHT].distance (left_skyline);
Both Mike and Janek thought the accidentals needed a bit more padding
for close intervals, so I think Janek should try horizon_padding here
with distance(left_skyline, 0.1)
If you think it worth making a tunable property of AccidentalPlacement,
fine. But the old parameters were not tunable, and better to have a
non-tunable correct spacing than non-tunable incorrect spacing.
http://codereview.appspot.com/6489086/
- Re: Uses horizontal skylines in accidental placement (issue 6489086), (continued)
Re: Uses horizontal skylines in accidental placement (issue 6489086),
k-ohara5a5a <=