[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: markup-commands rest-by-number and rest (issue 6850073)
From: |
thomasmorley65 |
Subject: |
Re: markup-commands rest-by-number and rest (issue 6850073) |
Date: |
Fri, 30 Nov 2012 01:33:08 +0000 |
On 2012/11/29 20:42:21, benko.pal wrote:
On 2012/11/29 00:41:14, thomasmorley65 wrote:
> On 2012/11/27 20:03:06, benko.pal wrote:
>
> > > Did you had a look on the compiled output of the new reg-tests?
I did now,
Thanks for doing this.
it's OK with me.
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly
File input/regression/markup-rest-styles.ly (right):
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly#newcode25
input/regression/markup-rest-styles.ly:25: '(-3 -2 -1 0 1 2 3 4 5 6
7))))))))
please fix indentation, this and the next list are at quite different
levels.
similarly in the other .ly file.
Couldn't find a guideline to do correct indentation here.
I ask on -devel
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest.ly
File input/regression/markup-rest.ly (right):
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest.ly#newcode27
input/regression/markup-rest.ly:27: (if (>= duration 0) dots "")))))
this if looks superfluous
Yep.
Will delete it.
https://codereview.appspot.com/6850073/
- Re: markup-commands rest-by-number and rest (issue 6850073), (continued)
- Re: markup-commands rest-by-number and rest (issue 6850073), thomasmorley65, 2012/11/25
- Re: markup-commands rest-by-number and rest (issue 6850073), benko . pal, 2012/11/26
- Re: markup-commands rest-by-number and rest (issue 6850073), dak, 2012/11/26
- Re: markup-commands rest-by-number and rest (issue 6850073), dak, 2012/11/26
- Re: markup-commands rest-by-number and rest (issue 6850073), benko . pal, 2012/11/26
- Re: markup-commands rest-by-number and rest (issue 6850073), thomasmorley65, 2012/11/26
- Re: markup-commands rest-by-number and rest (issue 6850073), benko . pal, 2012/11/27
- Re: markup-commands rest-by-number and rest (issue 6850073), thomasmorley65, 2012/11/28
- Re: markup-commands rest-by-number and rest (issue 6850073), benko . pal, 2012/11/29
- Re: markup-commands rest-by-number and rest (issue 6850073),
thomasmorley65 <=