[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Report unterminated ties hanging at end of input (issue 7019044)
From: |
pkx166h |
Subject: |
Report unterminated ties hanging at end of input (issue 7019044) |
Date: |
Wed, 26 Dec 2012 21:25:21 +0000 |
Reviewers: zefram_fysh.org,
Message:
Issue 3062 - patch created by 'Zefram', but submitted by James
Description:
Report unterminated ties hanging at end of input
Issue 3062
LP doesn't report unterminated ties that are left hanging at the end
of input. Compare { a2~ r2 } (which warns) with { a2~ } (which
doesn't).
Contrast against the handling of slurs, where both { a2( r2 } and { a2(
}
warn.
Please review this at https://codereview.appspot.com/7019044/
Affected files:
M lily/tie-engraver.cc
Index: lily/tie-engraver.cc
diff --git a/lily/tie-engraver.cc b/lily/tie-engraver.cc
index
07eb9196c78101a2c58ca5d4b1dabbc77cef9ad8..aa8544bcca0a05fc5a13090f82f6619f09678134
100644
--- a/lily/tie-engraver.cc
+++ b/lily/tie-engraver.cc
@@ -88,6 +88,7 @@ protected:
void typeset_tie (Grob *);
void report_unterminated_tie (Head_event_tuple const &);
bool has_autosplit_end (Stream_event *event);
+ virtual void finalize ();
public:
TRANSLATOR_DECLARATIONS (Tie_engraver);
};
@@ -131,6 +132,14 @@ Tie_engraver::has_autosplit_end (Stream_event *event)
}
void
+Tie_engraver::finalize ()
+{
+ vector<Head_event_tuple>::iterator it = heads_to_tie_.begin ();
+ for (; it < heads_to_tie_.end (); it++)
+ report_unterminated_tie (*it);
+}
+
+void
Tie_engraver::process_music ()
{
bool busy = event_;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Report unterminated ties hanging at end of input (issue 7019044),
pkx166h <=