Re: Issue 754: \transpose should not affect \transposition (issue 7304044)

[dak]

On 2013/02/06 07:11:34, Keith wrote:
> This works, including midi and cues between transposing instruments.

> I somewhat recommend doing only patch set 1 and the update to the
regtest
> documentation in set 3.
> (Or, at least put the change in patchset 2 as a separate commit, with
a
> convert-ly rule to say NOTSMART on any instrumentTransposition in user
input.)

Well, the current commit structure is

commit 055502c402fc90ba208e48c39e6d4f1c50a19fa6
Author: David Kastrup <address@hidden>
Date:   Tue Feb 5 14:48:46 2013 +0100

    Invert the meaning of instrumentTransposition again.

    This basically reverts commit
1965ca6b70aaf2c04a25ace9ed3f1fb4e1222f5a
    and the preceding one.

    Files affected:

        lily/note-performer.cc
        lily/quote-iterator.cc
        ly/music-functions-init.ly
        scm/define-context-properties.scm

commit 881f2ef1698f1d01276212bb826a31b4e9edd141
Author: David Kastrup <address@hidden>
Date:   Tue Feb 5 17:31:48 2013 +0100

    Adapt input/regression/quote-transposition.ly to new realities

commit f4bc3312b498d9bf304d82b7d56fcd6d872a5dd6
Author: David Kastrup <address@hidden>
Date:   Tue Feb 5 12:06:26 2013 +0100

    Issue 754: \transpose should not affect \transposition

We really need to check out Gerrit at some point of time.  I don't see
the point in _not_ inverting the instrumentTransposition sign: our
documentation gets it wrong, and all regtests are wrong.  What is a
nuisance is that marking QuoteMusic from \cueDuringWithTranspose (or
whatever it is called) as untransposable in order to save
quote-transposition from tampering is not feasible as 'element _has_
to be transposed.

I am currently rewriting the whole mess of \cueDuringWhatever to give
it a sensible interface.  LilyPond is sometimes such an arcane heap
of junk.


https://codereview.appspot.com/7304044/