Re: Spacing with empty contexts; issue 1669 (issue 4515158)

[address@hidden]

On 11 févr. 2013, at 06:41, address@hidden wrote:

> 
> https://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc
> File lily/align-interface.cc (right):
> 
> https://codereview.appspot.com/4515158/diff/2009/lily/align-interface.cc#newcode222
> lily/align-interface.cc:222: dy = max (dy, min_distance);
> On 2013/02/11 05:01:28, MikeSol wrote:
> 
>> Couldn't there just be a vector<bool> ignore_me that contains the
> result
>> request_suicide for all elements (when pure)?  Then, the for loop
> would be
>> continued for these elements and they wouldn't have to be removed in
>> get_skylines.
> 
> I think yes. ('removed_as_empty' would be a good name)
> That array could be built by get_skylines(), since it already calls
> pure_height(), which in turn calls request_suicide(..., start, end).
> 
> To truly distinguish the concepts of 'empty' versus 'removed', we could,
> in get_skylines line 98
> else if ( !(removed_as_empty[i] = request_suicide(elements[i], start,
> end)))
> but that results in an additional call to request_suicide() per
> VertAxisGroup per pass through the line-breaking

Ok - I'll be able to work on this once the assertion error clears up from 
annotate-spacing (reported to the bug list a few minutes ago).

Cheers,
MS