|
| From: | lemzwerg |
| Subject: | Re: Restore dots that overflow chords; issue 3179 (issue 8266047) |
| Date: | Mon, 08 Apr 2013 06:42:45 +0000 |
LGTM, with minor nits. Thanks for the patch! https://codereview.appspot.com/8266047/diff/15001/input/regression/chord-dots.ly File input/regression/chord-dots.ly (left): https://codereview.appspot.com/8266047/diff/15001/input/regression/chord-dots.ly#oldcode21 input/regression/chord-dots.ly:21: } Please extend the regtest so that it covers double dotted notes and chords also. https://codereview.appspot.com/8266047/diff/15001/lily/dot-column.cc File lily/dot-column.cc (right): https://codereview.appspot.com/8266047/diff/15001/lily/dot-column.cc#newcode277 lily/dot-column.cc:277: "note-collision " Any reason for a non-alphabetical sorting? https://codereview.appspot.com/8266047/
| [Prev in Thread] | Current Thread | [Next in Thread] |