lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Standardizes use of empty extents in pure heights and skylines. (iss


From: k-ohara5a5a
Subject: Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)
Date: Fri, 12 Apr 2013 19:29:46 +0000


https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc
File lily/skyline.cc (right):

https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc#newcode370
lily/skyline.cc:370: if (x1 >= last_end)
Oops.  This controls whether to put an empty, -inf height, building in
the gap. (When do we ever want Building data structures marking gaps?
The skyline concept seems to allow for gaps.)

These zero-width anti-buildings would not have any effect, except that
they are drawn (issue 3311) but they are not the boxes that surprised us
when they disappeared (issue 3161).

Probably safest to put back the x1 > last_end + EPS

https://codereview.appspot.com/7310075/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]