[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds padding around extender of line-spanners. (issue 8819043)
|
From: |
address@hidden |
|
Subject: |
Re: Adds padding around extender of line-spanners. (issue 8819043) |
|
Date: |
Sat, 20 Apr 2013 10:25:29 +0300 |
On 20 avr. 2013, at 08:06, address@hidden wrote:
>
> https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc
> File lily/line-spanner.cc (right):
>
> https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371
> lily/line-spanner.cc:371: // actual stencil bounds may be different
> The actual stencil bounds are (inf , -inf) if someone sets style=none
> When I try this on input/regression/dynamics-alignment-no-line.ly the
> while loop in add_grobs_of_one_priority() takes forever.
>
> https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode377
> lily/line-spanner.cc:377: Real new_left_y = minmax (-d, extremity,
> line_left[Y_AXIS] + d * skyline_spanner_padding);
> The smaller of the extent of the cresc.--- and the line padded by
> skyline_spanner_padding. Is that what you want?
>
Yeah, because we never want the padding going outside of the grob.
Cheers,
MS