[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
replaced function argument 'string' by 'const string &' where it makes s
|
From: |
k-ohara5a5a |
|
Subject: |
replaced function argument 'string' by 'const string &' where it makes sense to avoid unnecessary co… (issue 13 537043) |
|
Date: |
Fri, 06 Sep 2013 21:42:23 +0000 |
I tried to go through and look for unintended consequences.
I guess f(const string &s) is conventional in C++, so I guess this looks
good to me.
https://codereview.appspot.com/13537043/diff/1/lily/file-name-map.cc
File lily/file-name-map.cc (left):
https://codereview.appspot.com/13537043/diff/1/lily/file-name-map.cc#oldcode32
lily/file-name-map.cc:32: s = file_name_map_global[s];
Maybe the intent was to change the parameter in the caller,
lily/parser-scheme.cc:121, but probably not.
https://codereview.appspot.com/13537043/
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- replaced function argument 'string' by 'const string &' where it makes sense to avoid unnecessary co… (issue 13 537043),
k-ohara5a5a <=