lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add documentation for the music function \alterBroken to the NR. (is


From: tdanielsmusic
Subject: Re: Add documentation for the music function \alterBroken to the NR. (issue 15060044)
Date: Sat, 19 Oct 2013 09:50:43 +0000

LGTM with a couple of nitpicks and a query
(although I haven't tried a make doc to
check the appearance of the examples).

At first I was a little concerned about the
explanations in what is supposed to be a
_reference_ manual, but in this case I think
they are justified.  They are well-written,
not overly long, and the command is quite complex.

Trevor



https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely#newcode4318
Documentation/notation/changing-defaults.itely:4318:
"to" -> "on"

https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely#newcode4369
Documentation/notation/changing-defaults.itely:4369:
replace full stop by a comma

https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely#newcode4370
Documentation/notation/changing-defaults.itely:4370:
drop "to name several"

https://codereview.appspot.com/15060044/diff/1/Documentation/notation/changing-defaults.itely#newcode4396
Documentation/notation/changing-defaults.itely:4396:
Should there be a warning about not using \break
to enforce line breaks?

https://codereview.appspot.com/15060044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]