Re: lilly_libcxx.patch for building against libc++

[Jack Howarth]

On Thu, Nov 14, 2013 at 09:55:33PM +0100, David Kastrup wrote:
> Jack Howarth <address@hidden> writes:
> 
> >    The attached patch, lilly_libcxx.patch, contains the changes which allow 
> > lilypond 2.17.95
> > to build against libc++ on Xcode 10.9 with the clang++ compiler. There is a 
> > glitch in the
> > configure/makefiles currently that requires that the user pass 
> > -DHAVE_STL_DATA_METHOD on
> > CXXFLAGS. The problem is odd as configure seems able to set...
> >
> > /* define if you have stl data () method */
> > #define HAVE_STL_DATA_METHOD 1
> >
> > in the top level config.hh but it doesn't seem to get passed down to 
> > flowers/include/std-vector.hh
> > when included in file-path.cc.
> 
> See <URL:http://code.google.com/p/lilypond/issues/detail?id=3656>
> 
> Can you explain what the problem with to_string is actually about?  Can
> we fix this in a way that does not require explicit scoping?
> 
> -- 
> David Kastrup

David,
    I can confirm that the patch...

--- lilypond-2.17.95/flower/file-path.cc.orig   2013-11-04 04:29:55.000000000 
-0500
+++ lilypond-2.17.95/flower/file-path.cc        2013-11-14 16:55:11.000000000 
-0500
@@ -23,7 +23,6 @@
 #include <cstdio>
 #include <cerrno>
 
-#include "config.hh"
 #if HAVE_SYS_STAT_H
 #include <sys/stat.h>
 #endif
--- lilypond-2.17.95/flower/include/std-vector.hh.orig  2013-11-14 
16:49:50.000000000 -0500
+++ lilypond-2.17.95/flower/include/std-vector.hh       2013-11-14 
16:50:14.000000000 -0500
@@ -20,6 +20,8 @@
 #ifndef STD_VECTOR_HH
 #define STD_VECTOR_HH
 
+#include "config.hh"
+
 #if 0
 
 /*

fixes http://code.google.com/p/lilypond/issues/detail?id=3656 and eliminates 
the 
             Jack