lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Implement \beamExceptions function fishing exceptions from beamed mu


From: dak
Subject: Re: Implement \beamExceptions function fishing exceptions from beamed music. (issue 34880043)
Date: Sun, 01 Dec 2013 13:01:40 +0000

Reviewers: janek, Graham Percival,

Message:
On 2013/12/01 12:32:34, janek wrote:
I very much like the simplification in the user interface!
If i understand correctly, this function will overwrite beamExceptions
with the
pattern extracted from the music.

No.  It converts the given music into a form that can be placed into the
beamExceptions property.  Examples and documentation are intended to be
quite clear about that.  Please point out where you consider it
deficient.

Would it be possible to instead have a function \addBeamException that
would
take just one pattern and _add it_ to the current beamExceptions?  I
think that
would make the user interface even better.

There is no "instead".  What you do with the extracted data is your own
choice.  Assigning to beamExceptions via \set is one obvious use case.
Using it as an argument in \overrideBeamSettings is another.  If you
want to write a function that will use applyContext for getting the
existing setting and merging it with something you may specify in Scheme
or by using \beamExceptions, feel free to do so in a separate issue.

I don't think that there is much of a point to it since beam exceptions
act as a set and having too many closely named functions for fiddling
with beam settings will confuse rather than help.

Description:
Implement \beamExceptions function fishing exceptions from beamed music.


Also contains commits

Change documentation and regtests for \beamExceptions

Add unfold-repeats-fully function which will expand repeats in the data

Please review this at https://codereview.appspot.com/34880043/

Affected files (+137, -62 lines):
  M Documentation/notation/rhythms.itely
  M input/regression/auto-beam-exceptions.ly
  M input/regression/les-nereides.ly
  M input/regression/tablature-slurs-with-beams.ly
  M ly/music-functions-init.ly
  M scm/auto-beam.scm
  M scm/music-functions.scm





reply via email to

[Prev in Thread] Current Thread [Next in Thread]