[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Parser: make optional arguments compatible with lookahead (issue 417
From: |
lemzwerg |
Subject: |
Re: Parser: make optional arguments compatible with lookahead (issue 41720043) |
Date: |
Fri, 13 Dec 2013 06:47:29 +0000 |
https://codereview.appspot.com/41720043/diff/1/lily/parser.yy
File lily/parser.yy (right):
https://codereview.appspot.com/41720043/diff/1/lily/parser.yy#newcode1073
lily/parser.yy:1073: if (!unsmob_music ($$))
What's more annoying is that the copy&paste passages often use spaces
instead of tabs, while the global indentation style is supposed to use
tabs.
This is what I'm referring to. I find such issues irritating, but maybe
this is only me.
The inconsistency is somewhat annoying, but in the interest of letting
"git blame" work, gratuitous changes while moving lines around are not
a good idea.
Yep. There are more such issues in the file, BTW. I'm quite unhappy
that we can't fix this easily without obfuscating results of `blame'
command...
https://codereview.appspot.com/41720043/