[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds outside-staff-interface and outside-staff-axis-group-interface
|
From: |
dak |
|
Subject: |
Re: Adds outside-staff-interface and outside-staff-axis-group-interface (issue 37950044) |
|
Date: |
Wed, 25 Dec 2013 22:07:42 +0000 |
Spacing problems. Nothing requiring to prolong the review, but should
be fixed before pushing.
https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm
File scm/define-grobs.scm (right):
https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newcode355
scm/define-grobs.scm:355: outside-staff-axis-group-interface))))))
Don't use tabs in Scheme files. Incidentally, this whole file only
contained a single tab previous to this patch, and that single tab is
0c849c547 scm/define-grobs.scm (Mike Solomon 2013-08-27
08:44:23 +0300 171) (cross-staff . ,ly:arpeggio::calc-cross-staff)
It's probably sufficient to run scripts/auxiliar/fixscm.sh on the file
before committing, but it's not clear that this will not affect other
lines.
https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newcode1984
scm/define-grobs.scm:1984: slur-interface))))))
Tabs again.
https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newcode2295
scm/define-grobs.scm:2295: outside-staff-axis-group-interface))))))
Tabs again
https://codereview.appspot.com/37950044/diff/40001/scm/define-grobs.scm#newcode2734
scm/define-grobs.scm:2734: outside-staff-axis-group-interface))))))
More tabs.
https://codereview.appspot.com/37950044/