lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patches to push


From: David Kastrup
Subject: Re: Patches to push
Date: Sun, 12 Jan 2014 10:43:42 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Urs Liska <address@hidden> writes:

> Hi devels,
>
> would please someone push the attached patches to staging?
>
> I've chained them on top of staging
> (19fa6068cf3a7c5f02c13d5b57be895665da00bf) by cherry-picking them to
> _one_ branch (not single branches for each patch)
>
> and successfully ran make website.

Pushed this to staging as commits

commit b86682d0cd34af40f0436ad97a2659a827a698b5
Author: Urs Liska <address@hidden>
Date:   Tue Jan 7 12:51:02 2014 +0100

    Issue 3785:Web:Introduction: Reword "Our Goal" box
    
    The content of this box was somewhat confusing and inconsistent. See
    http://lists.gnu.org/archive/html/lilypond-devel/2014-01/msg00011.html
    
    This commit tries to incorporate the suggestions made in this thread
    as far as I considered appropriate.

commit 52a5d6c1a6bd722b9f04950b2d9ba6cc7f25d546
Author: Urs Liska <address@hidden>
Date:   Tue Jan 7 12:51:02 2014 +0100

    Issue 3785:Web:Background: Reword intr. paragraph
    
    I've always found this page confusing because I didn't understand
    why there is this "placeholder" page.
    This commit addresses this by making the "manual" issue explicit.
    
    Additionally I consider it more useful to _first_ tell the reader
    what it is and _then_ advise him to skip the essay instead of
    _immediately_ telling him "Probably you won't want to read this".
    If it is necessary to have the link at the end of a paragraph
    (and not only of a sentence) I'd simply insert a new paragraph
    after the link.

commit b0ec9ceced91d8dc9a2c6a95c71dbf936e33699d
Author: Urs Liska <address@hidden>
Date:   Tue Jan 7 12:35:32 2014 +0100

    Issue 3785: Web:Reviews: Add title box
    
    Same as https://codereview.appspot.com/38560044/
    The Introduction pages should have a "title box"

commit ec36bdf4bd3a8a2091baa1685fd54a4c6a570fb4
Author: Urs Liska <address@hidden>
Date:   Tue Jan 7 12:30:54 2014 +0100

    Issue 3785: Web:Productions: Add title box
    
    As stated in https://codereview.appspot.com/48450044/
    I think the Introduction pages should have a title box
    giving the user a first idea about the page.
    
    In this case the visitor (currently) would reach the page,
    doesn't see a heading and is faced two boxes,
    "Concerts" and "Published sheet music" without further introduction.

commit 4eba488b39eb3c262735d33b3e4ea6676a962abb
Author: Urs Liska <address@hidden>
Date:   Tue Jan 7 12:18:35 2014 +0100

    Issue 3785: Web:Examples: Enclose in box
    
    I think the pages below Introduction (and probably Community too)
    should consistently start with a box and a subheading,
    because there is no eye-catching page heading.
    
    This is _one_ option to do that for the Examples page.
    Others would be:
    
    - Make that @div only enclose the introductory paragraph
    - enclose the introductory paragraph _and_
      - add a headingless div around the examples _or_
      - add a div with @subheading "Gallery"


Please update the issue accordingly.

-- 
David Kastrup



reply via email to

[Prev in Thread] Current Thread [Next in Thread]