|
From: | Phil Holmes |
Subject: | Re: two patches for lilypad: accept? |
Date: | Sat, 6 Sep 2014 15:27:02 +0100 |
To: <address@hidden> Cc: "Phil Holmes" <address@hidden> Sent: Saturday, September 06, 2014 9:27 AM Subject: two patches for lilypad: accept?
Hi guys, I see that there's two patches for lilypad: https://github.com/gperciva/lilypad/pull/4 https://github.com/gperciva/lilypad/pull/3 Are these good? I think that Phil Holmes (and Christian Hitz) can accept them with the github interface, but if not, please let me know if I should accept them. Unfortunately I'm preparing for a presentation at work (I'm now at AIST, Tsukuba, Japan) on Monday, and in any case I've forgotten most of what I used to know about GUB / lilypad / etc. Cheers, - Graham
I've been pondering this, and I believe the correct thing will be to accept them. I need to have a look on my GUB machine to try to work out how lilypad is made, and so can run a test compile after these changes, and revert them if something goes wrong.
--Phil Holmes
[Prev in Thread] | Current Thread | [Next in Thread] |