Re: Issue 4154: Compact Chord Symbols Patch (issue 153160043 by address@hidden)

[Richard Shann]

On Wed, 2014-10-08 at 17:41 +0000, address@hidden wrote:
> Reviewers: ,
> 
> 
> https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm
> File scm/chord-ignatzek-names.scm (right):
> 
> https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm#newcode98
> scm/chord-ignatzek-names.scm:98: (vector-ref #("C" "D" "E" "F" "G" "A"
> "B") (ly:pitch-notename
> This looks like a bad idea.  It does not obey the various chord name
> languages.  It does not use the same callbacks.  It is a large
> duplication of code not connected with the other code and not using the
> same options, functionality and interfaces.

When I saw this (on the lilypond-devel mailing list) I thought this was
a comment about the existing code. The code quoted is the existing code,
which I haven't changed.
My code does not generate any chord names, so it can't obey any chord
name languages, it just typesets the elements of the chord name in a
more compact fashion.

Sorry for not replying earlier, but I did think that my patch had
sparked a debate about the quality of the original file, not my patch to
it, which is purely concerned with how the markup is created for the
chord names as generated by the existing code.

Richard


> 
> Can't you try to integrate this kind of code better with the existing
> code, both regarding the code that is called as well as the naming
> conventions and functionality that are available?
> 
> Description:
> Issue 4154: Compact Chord Symbols Patch
> 
> Please review this at https://codereview.appspot.com/153160043/
> 
> Affected files (+100, -26 lines):
>    M scm/chord-ignatzek-names.scm
>    M scm/define-context-properties.scm
> 
> 
> 
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel