[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by addres
From: |
lilyliska |
Subject: |
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden) |
Date: |
Sun, 26 Apr 2015 00:01:14 +0000 |
On 2015/04/25 22:58:56, Carl wrote:
On 2015/04/25 11:54:01, benko.pal wrote:
> 2015-04-25 10:20 GMT+02:00 <mailto:address@hidden>:
> > Thank you for picking this up. It is certainly an improvement
already.
> >
> > However: In an example where 8 32th notes are subdivided by 16th
notes
> > ony the first and third subdivision should have two beams, the
second
> > one only one beam.
> >
> > Put differently: when there is following a total of an eighth
note's
> > worth there should be only one beam, even when that total is
itself
> > subdivided into two sixteenth notes. (Presumably that logic should
be
> > propagated to the situation of (nested shorter notes): when 16
64th
> > notes are subdivided by 32ths the divisions should should have the
> > following number of beams: 3-2-3-1-3-2-3.
>
> could you formulate this more generally?
> e.g. what to do with 12 32th notes?
>
> p
If we have a baseMoment of 1/16, the 12 32nd notes will occur in 6
pairs with 3
beams.
The 1st and 2nd pairs will be joined with a double beam, as will the
3rd and
4th, and the 5th and 6th.
The beam between the 2nd and 3rd pair will be a single beam, as will
the beam
between the 4th and 5th.
LGTM.
I don't understand the code, but the regression tests (and my own files)
produce the correct result now.
https://codereview.appspot.com/226700043/
- Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden), (continued)
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden), Carl . D . Sorensen, 2015/04/25
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden),
lilyliska <=
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden), lilyliska, 2015/04/25
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden), Carl . D . Sorensen, 2015/04/25
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden), lemzwerg, 2015/04/26
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden), lilyliska, 2015/04/26
Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by address@hidden), tdanielsmusic, 2015/04/26