lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 4365: Add ly_is_smob<T>(S) to check if S is a smob of typeT. (


From: Phil Holmes
Subject: Re: Issue 4365: Add ly_is_smob<T>(S) to check if S is a smob of typeT. (issue 236850043 by address@hidden)
Date: Sat, 2 May 2015 14:05:00 +0100

----- Original Message ----- From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Saturday, May 02, 2015 1:54 PM
Subject: Re: Issue 4365: Add ly_is_smob<T>(S) to check if S is a smob of typeT. (issue 236850043 by address@hidden)


On 2015/05/02 08:25:09, dak wrote:

Nope.  dynamic_cast is non-trivial operation that cannot be optimized
away at
compile time for almost any use.  Calling it for every instance of the
rather
ubiquitous is_smob query (ubiquitous enough that I made it an
operation separate
from unsmob and checked that the generated code was nicer) is
excessive.

When "Patchy the autobot says: passes tests" does that include any
profiling?


No. It tests that make and make doc complete successfully and that there are no regtest differences.

To test performance, you might like to run an unmodified version and this modified version against a reasonably complex lilypond source file.

--
Phil Holmes



reply via email to

[Prev in Thread] Current Thread [Next in Thread]