Re: Part combiner: generate mark events in scheme rather than C++ (issue 228700043 by address@hidden)

[dak]

https://codereview.appspot.com/228700043/diff/40001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/228700043/diff/40001/ly/music-functions-init.ly#newcode1135
ly/music-functions-init.ly:1135: \context Voice = "one" \with {
#one-context-settings } {}
Since you are using the arguments *-context-settings in a context mod
anyway, it does not seem to make sense to pass them as music:

https://codereview.appspot.com/228700043/diff/40001/ly/music-functions-init.ly#newcode1153
ly/music-functions-init.ly:1153: #{ \voiceOne #}
Shouldn't this rather be #{ \with \voiceOne #} instead?

Or the equivalent?

https://codereview.appspot.com/228700043/