lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Part_combine_iterator: simplify context substitution (issue 23807004


From: k-ohara5a5a
Subject: Re: Part_combine_iterator: simplify context substitution (issue 238070043 by address@hidden)
Date: Mon, 11 May 2015 05:04:14 +0000

This and the MMrest patch look sensible,
but it is a good idea to test them on some orchestral music from
mutopiaproject.  I tried them on a piece I have and saw no output
differences.


https://codereview.appspot.com/238070043/diff/1/lily/part-combine-iterator.cc
File lily/part-combine-iterator.cc (left):

https://codereview.appspot.com/238070043/diff/1/lily/part-combine-iterator.cc#oldcode210
lily/part-combine-iterator.cc:210: }
The use of loops to go through cases is HanWenn's style, but this is
mysterious.

https://codereview.appspot.com/238070043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]