Re: Issue 3229: Make \relative { ... } interpret the first pitch as an absolute one (issue 235000043 by address@hidden)

[dak]

Reviewers: Keith,


https://codereview.appspot.com/235000043/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/235000043/diff/1/Documentation/notation/pitches.itely#newcode169
Documentation/notation/pitches.itely:169: like @code{\relative @{ gis'''
@dots{} @}}
On 2015/05/12 06:16:37, Keith wrote:
> Probably you'll want to reverse the convert-ly to the text that talks
about the
> option to use \relative c'''{}

Well, it was more or less understood that this conversion would require
a followup rewrite.  I've just taken a look at some other commit
messages and there is, for example,

commit 6e4e9c4eacb94d68c11fd6b9062da4f724114860
Author: David Kastrup <address@hidden>
Date:   Fri Oct 18 12:29:37 2013 +0200

    Run scripts/auxiliar/update-with-convert-ly.sh

    Actually, this is an understatement.  This is the result of

    scripts/auxiliar/update-with-convert-ly.sh
    git checkout HEAD ly/{engraver,music-functions,property}-init.ly
input/regression/display-lily-tests.ly
Documentation/{,*/}learning/*.itely

    and then committing.

In a similar vein, it may be possible/feasible to exempt certain files
or directories here from the conversion if we figure out that we are
likely to cause more damage than good.

However, given the extensiveness of the patterns, it is likely less
effort to manually change passages back that are negatively affected.
More likely than not, in chapters talking explicitly about pitches.

https://codereview.appspot.com/235000043/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

https://codereview.appspot.com/235000043/diff/1/Documentation/notation/rhythms.itely#newcode450
Documentation/notation/rhythms.itely:450: >>>>>>> Run
scripts/auxiliar/update-with-convert-ly.sh
On 2015/05/12 06:16:37, Keith wrote:
> A few merge-failure reports made it into this upload, somehow.

Yeah, bummer.  Since I'll be rerunning the conversion, they won't be in
the final version (if I don't repeat the rebase mistake I apparently
did), but it's unnerving that the affected files still had no problem
passing Patchy.

Description:
Issue 3229: Make \relative { ... } interpret the first pitch as an
absolute one

The previous default of \relative { ... } being \relative c' { ... }
made c' more special than warranted.  Having to write
\relative f { ... } for this functionality seems awkward since f
serves no musical function but just happens to be the middle of the
scale.  Iff the scale is the standard scale.  The new definition of
\relative takes care to determine the "middle of the scale" reference
point properly even in the case of non-standard scales.

The conversion rules catch the cases where
a) \relative was used without a pitch argument.  In this case the
   pitch gets turned into c'
b) \relative x''' { ... is being used, with x''' being an arbitrary
   pitch and ... is a number of patterns where convert-ly can detect
   the first actual note reliably.

If the file contains \include or \language with a non-c-using notename
language, everything is left in place.

However, this exception is disabled in this commit as it is not
required on the LilyPond code base itself.

Please review this at https://codereview.appspot.com/235000043/

Affected files (+9737, -6736 lines):
  M Documentation/ca/learning/common-notation.itely
  M Documentation/ca/learning/fundamental.itely
  M Documentation/ca/learning/tutorial.itely
  M Documentation/ca/learning/tweaks.itely
  M Documentation/ca/usage/running.itely
  M Documentation/ca/usage/suggestions.itely
  M Documentation/cs/learning/common-notation.itely
  M Documentation/cs/learning/fundamental.itely
  M Documentation/cs/learning/tutorial.itely
  M Documentation/cs/learning/tweaks.itely
  M Documentation/cs/usage/lilypond-book.itely
  M Documentation/cs/usage/running.itely
  M Documentation/cs/usage/suggestions.itely
  M Documentation/de/essay/engraving.itely
  M Documentation/de/extending/programming-interface.itely
  M Documentation/de/extending/scheme-tutorial.itely
  M Documentation/de/learning/common-notation.itely
  M Documentation/de/learning/fundamental.itely
  M Documentation/de/learning/tutorial.itely
  M Documentation/de/learning/tweaks.itely
  M Documentation/de/notation/ancient.itely
  M Documentation/de/notation/changing-defaults.itely
  M Documentation/de/notation/chords.itely
  M Documentation/de/notation/editorial.itely
  M Documentation/de/notation/expressive.itely
  M Documentation/de/notation/fretted-strings.itely
  M Documentation/de/notation/input.itely
  M Documentation/de/notation/keyboards.itely
  M Documentation/de/notation/pitches.itely
  M Documentation/de/notation/repeats.itely
  M Documentation/de/notation/rhythms.itely
  M Documentation/de/notation/simultaneous.itely
  M Documentation/de/notation/spacing.itely
  M Documentation/de/notation/staff.itely
  M Documentation/de/notation/text.itely
  M Documentation/de/notation/vocal.itely
  M Documentation/de/notation/world.itely
  M Documentation/de/usage/external.itely
  M Documentation/de/usage/lilypond-book.itely
  M Documentation/de/usage/running.itely
  M Documentation/de/usage/suggestions.itely
  M Documentation/es/essay/engraving.itely
  M Documentation/es/extending/programming-interface.itely
  M Documentation/es/extending/scheme-tutorial.itely
  M Documentation/es/learning/common-notation.itely
  M Documentation/es/learning/fundamental.itely
  M Documentation/es/learning/tutorial.itely
  M Documentation/es/learning/tweaks.itely
  M Documentation/es/notation/ancient.itely
  M Documentation/es/notation/changing-defaults.itely
  M Documentation/es/notation/chords.itely
  M Documentation/es/notation/editorial.itely
  M Documentation/es/notation/expressive.itely
  M Documentation/es/notation/fretted-strings.itely
  M Documentation/es/notation/input.itely
  M Documentation/es/notation/keyboards.itely
  M Documentation/es/notation/pitches.itely
  M Documentation/es/notation/repeats.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/es/notation/simultaneous.itely
  M Documentation/es/notation/spacing.itely
  M Documentation/es/notation/staff.itely
  M Documentation/es/notation/text.itely
  M Documentation/es/notation/vocal.itely
  M Documentation/es/notation/world.itely
  M Documentation/es/usage/external.itely
  M Documentation/es/usage/lilypond-book.itely
  M Documentation/es/usage/running.itely
  M Documentation/es/usage/suggestions.itely
  M Documentation/essay/engraving.itely
  M Documentation/extending/programming-interface.itely
  M Documentation/extending/scheme-tutorial.itely
  M Documentation/fr/essay/engraving.itely
  M Documentation/fr/extending/programming-interface.itely
  M Documentation/fr/extending/scheme-tutorial.itely
  M Documentation/fr/learning/common-notation.itely
  M Documentation/fr/learning/fundamental.itely
  M Documentation/fr/learning/tutorial.itely
  M Documentation/fr/learning/tweaks.itely
  M Documentation/fr/notation/ancient.itely
  M Documentation/fr/notation/changing-defaults.itely
  M Documentation/fr/notation/chords.itely
  M Documentation/fr/notation/editorial.itely
  M Documentation/fr/notation/expressive.itely
  M Documentation/fr/notation/fretted-strings.itely
  M Documentation/fr/notation/input.itely
  M Documentation/fr/notation/keyboards.itely
  M Documentation/fr/notation/pitches.itely
  M Documentation/fr/notation/repeats.itely
  M Documentation/fr/notation/rhythms.itely
  M Documentation/fr/notation/simultaneous.itely
  M Documentation/fr/notation/spacing.itely
  M Documentation/fr/notation/staff.itely
  M Documentation/fr/notation/text.itely
  M Documentation/fr/notation/vocal.itely
  M Documentation/fr/notation/world.itely
  M Documentation/fr/usage/external.itely
  M Documentation/fr/usage/lilypond-book.itely
  M Documentation/fr/usage/running.itely
  M Documentation/fr/usage/suggestions.itely
  M Documentation/hu/essay/engraving.itely
  M Documentation/hu/learning/common-notation.itely
  M Documentation/hu/learning/fundamental.itely
  M Documentation/hu/learning/tutorial.itely
  M Documentation/hu/usage/lilypond-book.itely
  M Documentation/hu/usage/running.itely
  M Documentation/included/engraver-example.ily
  M Documentation/included/gonville.ly
  M Documentation/included/simple.ly
  M Documentation/it/learning/common-notation.itely
  M Documentation/it/learning/fundamental.itely
  M Documentation/it/learning/tutorial.itely
  M Documentation/it/learning/tweaks.itely
  M Documentation/it/notation/editorial.itely
  M Documentation/it/notation/expressive.itely
  M Documentation/it/notation/pitches.itely
  M Documentation/it/notation/repeats.itely
  M Documentation/it/notation/rhythms.itely
  M Documentation/it/notation/simultaneous.itely
  M Documentation/it/notation/staff.itely
  M Documentation/it/notation/text.itely
  M Documentation/it/notation/vocal.itely
  M Documentation/it/usage/external.itely
  M Documentation/it/usage/lilypond-book.itely
  M Documentation/it/usage/running.itely
  M Documentation/it/usage/suggestions.itely
  M Documentation/ja/learning/common-notation.itely
  M Documentation/ja/learning/fundamental.itely
  M Documentation/ja/learning/tutorial.itely
  M Documentation/ja/learning/tweaks.itely
  M Documentation/ja/notation/changing-defaults.itely
  M Documentation/ja/notation/chords.itely
  M Documentation/ja/notation/editorial.itely
  M Documentation/ja/notation/expressive.itely
  M Documentation/ja/notation/fretted-strings.itely
  M Documentation/ja/notation/input.itely
  M Documentation/ja/notation/keyboards.itely
  M Documentation/ja/notation/pitches.itely
  M Documentation/ja/notation/repeats.itely
  M Documentation/ja/notation/rhythms.itely
  M Documentation/ja/notation/simultaneous.itely
  M Documentation/ja/notation/spacing.itely
  M Documentation/ja/notation/staff.itely
  M Documentation/ja/notation/text.itely
  M Documentation/ja/notation/vocal.itely
  M Documentation/ja/notation/world.itely
  M Documentation/ja/usage/external.itely
  M Documentation/ja/usage/lilypond-book.itely
  M Documentation/ja/usage/running.itely
  M Documentation/ja/usage/suggestions.itely
  M Documentation/learning/common-notation.itely
  M Documentation/learning/fundamental.itely
  M Documentation/learning/tutorial.itely
  M Documentation/learning/tweaks.itely
  M Documentation/ly-examples/aucun-snippet.ly
  M Documentation/ly-examples/orchestra.ly
  M Documentation/nl/learning/common-notation.itely
  M Documentation/nl/learning/fundamental.itely
  M Documentation/nl/learning/tutorial.itely
  M Documentation/nl/learning/tweaks.itely
  M Documentation/notation/ancient.itely
  M Documentation/notation/changing-defaults.itely
  M Documentation/notation/chords.itely
  M Documentation/notation/editorial.itely
  M Documentation/notation/expressive.itely
  M Documentation/notation/fretted-strings.itely
  M Documentation/notation/input.itely
  M Documentation/notation/keyboards.itely
  M Documentation/notation/pitches.itely
  M Documentation/notation/repeats.itely
  M Documentation/notation/rhythms.itely
  M Documentation/notation/simultaneous.itely
  M Documentation/notation/spacing.itely
  M Documentation/notation/staff.itely
  M Documentation/notation/text.itely
  M Documentation/notation/vocal.itely
  M Documentation/notation/world.itely
  M Documentation/snippets/accordion-discant-symbols.ly
  M Documentation/snippets/adding-an-extra-staff.ly
  M Documentation/snippets/adding-an-extra-staff-at-a-line-break.ly
  M Documentation/snippets/adding-fingerings-to-a-score.ly
  M Documentation/snippets/adding-orchestral-cues-to-a-vocal-score.ly
  M  
Documentation/snippets/adding-parentheses-around-an-expressive-mark-or-chordal-note.ly
  M Documentation/snippets/adding-the-current-date-to-a-score.ly
  M Documentation/snippets/adding-timing-marks-to-long-glissandi.ly
  M Documentation/snippets/adjusting-grace-note-spacing.ly
  M Documentation/snippets/adjusting-lyrics-vertical-spacing.ly
  A Documentation/snippets/aligning-marks-with-various-notation-objects.ly
  M  
Documentation/snippets/aligning-objects-created-with-the--mark-command.ly
  M Documentation/snippets/aligning-syllables-with-melisma.ly
  M  
Documentation/snippets/allowing-fingerings-to-be-printed-inside-the-staff.ly
  M Documentation/snippets/alternative-breve-notes.ly
  M Documentation/snippets/ambitus.ly
  M Documentation/snippets/anglican-psalm-template.ly
  M Documentation/snippets/automatically-change-durations.ly
  M  
Documentation/snippets/automatically-changing-the-stem-direction-of-the-middle-note-based-on-the-melody.ly
  A Documentation/snippets/beam-grouping-in-7-8-time.ly
  M Documentation/snippets/breathing-signs.ly
  M Documentation/snippets/caesura-railtracks-with-fermata.ly
  M Documentation/snippets/centering-markup-on-note-heads-automatically.ly
  [[ 570 additional files ]]