[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 4205: Improve part combiner's rest analysis (issue 174610043 b
From: |
k-ohara5a5a |
Subject: |
Re: Issue 4205: Improve part combiner's rest analysis (issue 174610043 by address@hidden) |
Date: |
Wed, 13 May 2015 04:55:22 +0000 |
I noticed the same bug with rests and skips. I'm using the patch below
with success on my own music, but I haven't tried it on the regtest
suite yet.
https://codereview.appspot.com/174610043/diff/20001/scm/part-combiner.scm
File scm/part-combiner.scm (right):
https://codereview.appspot.com/174610043/diff/20001/scm/part-combiner.scm#newcode51
scm/part-combiner.scm:51: (filter f? (events vs)))
I suggest also sorting rests before skips, so that we compare the rest
to the rest if parts contain a mix
(append (filter (lambda(x) (ly:in-event-class? x 'rest-event))
(events vs))
(filter (lambda(x) (ly:in-event-class? x 'skip-event))
(events vs))))
https://codereview.appspot.com/174610043/diff/20001/scm/part-combiner.scm#newcode457
scm/part-combiner.scm:457: (= 1 (length rests2))
(< 0 (length rests1))
(< 0 (length rests2))
https://codereview.appspot.com/174610043/
- Re: Issue 4205: Improve part combiner's rest analysis (issue 174610043 by address@hidden),
k-ohara5a5a <=