Re: time-scaled-music-iterator.hh

[David Kastrup]

Dan Eble <address@hidden> writes:

> I seek a word of approval to delete
> lily/include/time-scaled-music-iterator.hh without the full review
> process.  It looks like it hasn’t been used since this commit.
>
> commit 131fa6b31beae464e4e6730dc11a3e406e4893a4
> Author: Neil Puttock <address@hidden>
> Date:   Wed Feb 17 22:30:47 2010 +0000
>
>     Rename Time_scaled_music_iterator -> Tuplet_iterator.
> — 

I don't see that the state before this commit references it either.

    git log -S time-scaled-music-iterator.hh

to the rescue!  It would appear that reference to it was removed in

commit 19e1e4e33f38a628fd56df3b8b5095b74fd001f7
Author: Erik Sandberg <address@hidden>
Date:   Sat Jun 10 19:24:33 2006 +0000

    Made tupletSpannerDuration work again.

but it was factored out from time-scaled-music-iterator.cc in

commit 9f3572d98bb948c9689cd1f75401a029451fa001
Author: Erlend Aasland <address@hidden>
Date:   Wed May 31 01:47:30 2006 +0000

    Fix some bugs in the dynamic engraver and PostScript backend

and removed previously in the suspiciously identically-named

commit e776b399d99dba5ea76eae44b701eba2ea4ec977
Author: Erik Sandberg <address@hidden>
Date:   Sat Jun 10 19:24:34 2006 +0000

    Made tupletSpannerDuration work again.

and then there also is

commit ea1b3696c02bb143fc7faf8b872a5c23c0725fef
Author: Han-Wen Nienhuys <address@hidden>
Date:   Fri Jan 14 12:36:39 2005 +0000

    remove file.


So while all this mess makes for an interesting history, there is no
denying that nothing has referenced this file since 2006 and it is
misleadingly diverged from the actual code/class being used in
lily/tuplet-iterator.cc.


In short: fine with me.  Push to staging, and we'll get notice of any
surprise problems anyway.

-- 
David Kastrup