Re: git-cl upload has stopped working?

[Carl Sorensen]

On 5/28/15 5:35 AM, "Dan Eble" <address@hidden> wrote:

>On May 27, 2015, at 16:17 , David Kastrup <address@hidden> wrote:
>> 
>> So what I did was pressed "Create Issue" on codereview.appspot.com which
>> tells you to use update.py and provides a download for it.  So I
>> downloaded it, overwrote the version in the git-cl directory (which does
>> not know about oauth2) with it, edited the --oauth2 option to default to
>> True (since I did not figure out how upload.py is getting called by
>> git-cl).
>
>--- git-cl.old  2015-05-28 07:17:39.466031501 -0400
>+++ git-cl      2015-05-28 07:32:45.550061049 -0400
>@@ -648,6 +648,7 @@
>   subject = desc.splitlines()[0]
>   upload_args.extend(['--title', subject])
>   upload_args.extend(['--message', desc])
>+  upload_args.append('--oauth2')

upload_args.append(['--oauth2'])


>   issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>   if not cl.GetRietveldIssue():
>     cl.SetRietveldIssue(issue)

So the set of steps that worked for me was:

0. Rename upload.py in the git-cl/ folder to upload.py.old.  On LilyDev3,
the git-cl folder is located at ~/git-cl.

1. Go to codereview.appspot.com, sign in, and create a new issue.  You
don't actually need to create an issue, but when you click on the create
issue button, you get to download the file upload.py.

2. Save the upload.py into the git-cl/ folder.

3.  Edit the git-cl file found in the git-cl/ folder to meet Dan's diff,
but I needed to place square brackets around the '--oauth2' argument.

After doing this, git-cl will open up a web browser and have me
authenticate.  I never get the success message I'm used to seeing from
git-cl (because it can't access Google Code), but it does upload the patch.

Thanks,

Carl