lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Doc: Update ../ly/Bagpipe.ly (issue 241270043 by address@hidden)


From: dak
Subject: Doc: Update ../ly/Bagpipe.ly (issue 241270043 by address@hidden)
Date: Thu, 11 Jun 2015 12:19:36 +0000


https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly
File ly/bagpipe.ly (left):

https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly#oldcode22
ly/bagpipe.ly:22: (c-flat . ,(ly:make-pitch 1 0 FLAT))
Why are you removing the definitions c-flat, f-flat, g-flat?

https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly
File ly/bagpipe.ly (right):

https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly#newcode14
ly/bagpipe.ly:14: \version "2.19.0"
Rewind the version?  Why?  Well, it does have the advantage that the
next run of update-with-convert-ly run will remove obsolete
parser/location arguments (see later).  But it seems saner to add the
file in the proper version.

https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly#newcode94
ly/bagpipe.ly:94: stemspace = #(define-music-function (parser location
extent) (pair?) #{
Please remove the parser and location arguments here.

https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly#newcode97
ly/bagpipe.ly:97: pgrace = #(define-music-function (parser location
notes) (ly:music?) #{
And here.

https://codereview.appspot.com/241270043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]