[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@
From: |
hanwenn |
Subject: |
Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden) |
Date: |
Wed, 26 Aug 2015 11:26:56 +0000 |
On 2015/08/26 11:22:18, dak wrote:
On 2015/08/26 11:17:23, hanwenn wrote:
> not LGTM
>
> I'll follow up on the bug.
Well, if anybody could it would be you, working at Google. But I
guess for now
you'll have to explain on the Rietveld review. Google Code has been
switched to
readonly.
"preparation of .. " : deriving from Grob is not a feature but a risk.
In fact, it would even be nice if Item and Spanner could disappear, but
that seems to be intractable.
I spent a giant amount of energy distangling formatting logic from C++
type hierarchy, so behaviors can be mixed and matched at runtime, and
this is taking a step in the opposite direction.
https://codereview.appspot.com/260810043/
- Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), nine . fierce . ballads, 2015/08/16
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), pkx166h, 2015/08/26
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), hanwenn, 2015/08/26
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), dak, 2015/08/26
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden),
hanwenn <=
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), nine . fierce . ballads, 2015/08/26
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), hanwenn, 2015/08/28
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), hanwenn, 2015/08/28
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), nine . fierce . ballads, 2015/08/28
- Re: Issue 4564: make Grob an abstract class (issue 260810043 by address@hidden), pkx166h, 2015/08/29