[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Implement make-bow-stencil, make-tie-stencil for use in markup-comma
From: |
simon . albrecht |
Subject: |
Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden) |
Date: |
Wed, 04 Nov 2015 00:28:27 +0000 |
Man, sorry, while not being up to your coding skills, I can make
nitpicks…
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode50
scm/stencil.scm:50: @var{bow-height} determines the heigth of the bow.
…height…
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode54
scm/stencil.scm:54: Both variables are supplied to support independant
usage.
…independent…
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode56
scm/stencil.scm:56: The task is done by calculating a horizontal bow
with appropiate length first,
…appropriate…
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode64
scm/stencil.scm:64: ;;;; (4) calculat control-points for a horizontal
bezier-curce, beginning
…curve…
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode67
scm/stencil.scm:67: ;;;; (6) move rotated conrol-points to match `start'
…control-points… (both preceding lines)
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode101
scm/stencil.scm:101: ;;;; (4) calculate control-points for a horizontal
bezier-curce,
…curve…
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode138
scm/stencil.scm:138: ;;;; (5) rotate conrol-points around '(0 . 0) to
match `stop'
…control-points…
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode148
scm/stencil.scm:148: ;;;; (6) move rotated conrol-points to match
`start'
…same here…
https://codereview.appspot.com/270640043/
- Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/03
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden),
simon . albrecht <=
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/04
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/08
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/08
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/08
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/10
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/10
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/11
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/12
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/13
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/13