[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Optional fraction after \afterGrace command (issue 304200043 by addr
From: |
dak |
Subject: |
Re: Optional fraction after \afterGrace command (issue 304200043 by address@hidden) |
Date: |
Thu, 28 Jul 2016 10:15:20 -0700 |
https://codereview.appspot.com/304200043/diff/20001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/304200043/diff/20001/Documentation/notation/rhythms.itely#newcode3436
Documentation/notation/rhythms.itely:3436: the length of the main note.
The default is set as
On 2016/07/24 22:59:35, simon.albrecht wrote:
The wording feels odd to me. Maybe:
This will put the grace notes after some space, equivalent
to a fraction of the duration of the main note.
?
Well, I just copied the original text here, just replacing "3/4" with "a
fraction". I'll see whether I can reword more to your liking.
https://codereview.appspot.com/304200043/diff/20001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/304200043/diff/20001/ly/music-functions-init.ly#newcode59
ly/music-functions-init.ly:59: afterGraceFraction = 6/8
On 2016/07/24 22:59:35, simon.albrecht wrote:
What would be the point of 6/8 instead of 3/4?
I just retained the original value. There is no point to it as far as I
am aware.
It's been that way since
commit 5d09e71683990a4615ea4e0c497db31c462e2345
Author: Han-Wen Nienhuys <address@hidden>
Date: Sun Nov 28 17:37:42 2004 +0000
*** empty log message ***
No rationale is found in the ChangeLog entries or similar information
and the NR documentation exclusively talks about 3/4.
I'll change this to 3/4. I just was too lazy to do all the research for
figuring out whether there was any discernible justification for it,
ever.
https://codereview.appspot.com/304200043/diff/20001/ly/music-functions-init.ly#newcode67
ly/music-functions-init.ly:67: @code{afterGraceFraction} which has a
default value of @code{6/8}.")
On 2016/07/24 22:59:35, simon.albrecht wrote:
(Same fraction as above.)
Acknowledged.
https://codereview.appspot.com/304200043/