lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Implement shorten-pair for Hairpin (issue 315350043 by address@hidde


From: thomasmorley65
Subject: Re: Implement shorten-pair for Hairpin (issue 315350043 by address@hidden)
Date: Sat, 14 Jan 2017 13:53:25 -0800

Again limited to the scm/ly-files:
LGTM
One nit:


https://codereview.appspot.com/315350043/diff/20001/Documentation/snippets/new/moving-the-ends-of-hairpins.ly
File Documentation/snippets/new/moving-the-ends-of-hairpins.ly (right):

https://codereview.appspot.com/315350043/diff/20001/Documentation/snippets/new/moving-the-ends-of-hairpins.ly#newcode18
Documentation/snippets/new/moving-the-ends-of-hairpins.ly:18: c'1~\<
I'd suggest to make it more clear what happens
if the tweaked hairpin spans between DynamicText like
  c'1~\p\< c'2~ c'\ffff\!
Maybe extend the 'hairpin'-example a bit or drop an additional line in
the texidoc-header about affecting the _visible_ length of the Hairpin,
opposed to the behaviour of 'minimum-length

https://codereview.appspot.com/315350043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]