[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Additions in event-listener.ly (issue 152600043 by address@hidden)
From: |
pkx166h |
Subject: |
Re: Additions in event-listener.ly (issue 152600043 by address@hidden) |
Date: |
Wed, 22 Mar 2017 00:02:43 -0700 |
On 2014/10/17 06:40:24, Valentin Villenave wrote:
Greetings Philippe and James,
this looks good overall, I just have one minor comment.
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly
File ly/event-listener.ly (right):
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode129
ly/event-listener.ly:129: (+ 60 (ly:pitch-semitones
AFAICS, .ly files use spaces, not tabs. Check the indentation.
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode144
ly/event-listener.ly:144: "note"
Strictly speaking, this isn't a "note". "Drumnote" may be too long,
how about
"stroke" or something else?
If someone could advise me on the suggestion by Valentine as I doubt the
author is going to reply to me and it will be doing the 'edit'.
https://codereview.appspot.com/152600043/
- Re: Additions in event-listener.ly (issue 152600043 by address@hidden),
pkx166h <=