Re: Implement extra-offset for system positioning (issue 324810043 by address@hidden)

[david . nalesnik]

Also added a "Changes" entry.

Thanks!


https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly
File input/regression/page-layout-extra-offset.ly (right):

https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly#newcode7
input/regression/page-layout-extra-offset.ly:7: printable area of the
page or the absolute position pecified by
On 2017/04/28 09:26:33, thomasmorley651 wrote:
> typo
> pecified->specified

Done.

https://codereview.appspot.com/324810043/diff/1/scm/page.scm
File scm/page.scm (right):

https://codereview.appspot.com/324810043/diff/1/scm/page.scm#newcode246
scm/page.scm:246: (extra-offset (ly:prob-property system 'extra-offset
(cons 0 0)))
On 2017/04/28 09:26:33, thomasmorley651 wrote:
> Why not directly '(0 . 0) instead of constructing it?
> Admittedly, starting with guile-2.2 set-car! (and similiar) will error
on
> literals, though this is not the case here.

Done.

https://codereview.appspot.com/324810043/