[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Create engravers for merging rests (issue 321930043 by address@hidde
|
From: |
thomasmorley65 |
|
Subject: |
Re: Create engravers for merging rests (issue 321930043 by address@hidden) |
|
Date: |
Mon, 12 Jun 2017 00:40:42 -0700 |
One nit. See below.
No need for a new patch-set, imho. You could change it right before
pushing.
Otherwise LGTM
https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
https://codereview.appspot.com/321930043/diff/160001/Documentation/notation/simultaneous.itely#newcode917
Documentation/notation/simultaneous.itely:917: parts. This can be
accomplished using the merge rests engraver.
I'd use the name, i.e. "Merge_rests_engraver"
https://codereview.appspot.com/321930043/
- Re: Create engravers for merging rests (issue 321930043 by address@hidden),
thomasmorley65 <=