|
From: | dak |
Subject: | Re: Let Merge_rests_engraver deal with dotted rests (issue 324310043 by address@hidden) |
Date: | Tue, 29 Aug 2017 00:31:20 -0700 |
https://codereview.appspot.com/324310043/diff/40001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): https://codereview.appspot.com/324310043/diff/40001/Documentation/notation/simultaneous.itely#newcode10 Documentation/notation/simultaneous.itely:10: @c \version "2.19.29" Version warrants changing to the version where the engraver got register. At least once you actually make use of the registration... https://codereview.appspot.com/324310043/diff/40001/Documentation/notation/simultaneous.itely#newcode933 Documentation/notation/simultaneous.itely:933: \consists \Merge_rests_engraver Uh, what? You could have written _this_ without registering the engraver. The point of registering the engraver is that you can write \consists Merge_rests_engraver or (I think that's the convention we usually use) \consists "Merge_rests_engraver" like with C++-defined engravers. https://codereview.appspot.com/324310043/
[Prev in Thread] | Current Thread | [Next in Thread] |