Re: Multiple properties for \override \override-lines markup (issue 331860043 by address@hidden)

[dak]

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly
File Documentation/snippets/keyboard-headword.ly (right):

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly#newcode31
Documentation/snippets/keyboard-headword.ly:31: \override #'((direction
. 1) (baseline-skip . 2)) {
On 2017/10/08 15:19:44, thomasmorley651 wrote:
> One {}-bracket-pair could be deleted as well.

Two, actually (all except the innermost one).  I'll take a look.

The {} reduction was manually, so it may have been
incomplete/inconsistent.

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm#newcode2530
scm/define-markup-commands.scm:2530: @lilypond[verbatim,quote]
On 2017/10/08 15:19:44, thomasmorley651 wrote:
> How about demonstrating in the example. Suggestion:
> \markup {
>    \undertie "undertied"
>    \override #'(offset . 15)
>    \undertie "offset undertied"
>    \override #'((offset . 15)(thickness . 3))
>    \undertie "offset thick undertied"
> }

Maybe. \markup { \line { ... } } is an abomination anyway.  Should be
just
\markup { ... }.  I'll take a look.

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm#newcode4026
scm/define-markup-commands.scm:4026: \\override-lines
#'(multi-measure-rest . #t)
On 2017/10/08 15:19:44, thomasmorley651 wrote:
> Why override_-lines_ here. Don't understand.

Because \override ... { x y z } is translated into
{ \override ... x \override ... y \override ... z }
which is wasteful.

Remember that everything that is called "-lines" in markup really is
talking about a markup _list_.  Whether it ends up in lines depends on
the usage.

https://codereview.appspot.com/331860043/