[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue #5246: Make empty scores abort engraving process (issue 332470
From: |
Dan Eble |
Subject: |
Re: Issue #5246: Make empty scores abort engraving process (issue 332470043 by address@hidden) |
Date: |
Fri, 22 Dec 2017 09:18:28 -0500 |
On Dec 21, 2017, at 23:06, address@hidden wrote:
>
> @@ -110,8 +110,7 @@ LY_DEFINE (ly_interpret_music_expression,
> "ly:interpret-music-expression",
>
> if (!iter->ok ())
> {
> - warning (_ ("no music found in score"));
> - /* todo: should throw exception. */
> + error (_ ("no music found in score"));
> return SCM_BOOL_F;
> }
Looking at this in isolation, I wonder whether “no music found” is the only
reason that iter might not be OK; in other words, was the message appropriate
before you arrived?
Regards,
—
Dan