[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: add dynamic n for “niente” to feta (issue 339090043 by address@hidde
|
From: |
lilypond |
|
Subject: |
Re: add dynamic n for “niente” to feta (issue 339090043 by address@hidden) |
|
Date: |
Thu, 04 Jan 2018 09:19:30 -0800 |
On 2018/01/01 17:36:41, lemzwerg wrote:
https://codereview.appspot.com/339090043/diff/80001/ps/encodingdefs.ps#newcode721
ps/encodingdefs.ps:721: /.notdef /.notdef /.notdef /.notdef /.notdef
Yes, the encoding vector should contain exactly 256 elements.
This isn’t the case in other vectors too, I’ll fix that with the next
patch set.
https://codereview.appspot.com/339090043/diff/80001/ps/encodingdefs.ps#newcode860
ps/encodingdefs.ps:860: /nine {<7c> show} def
The order in /LilyOtherEncoding doesn't matter. It's this very
encoding vector
that maps glyph names to glyph indices.
Ok. Looking at the resulting otf, type1, and svg fonts it doesn’t change
the encoding because “n” sits at its ASCII code, so I believe it’s ok to
shift the indices.
https://codereview.appspot.com/339090043/