[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: issue #1493: Problem with horizontal beams (issue 337560043 by addre
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: issue #1493: Problem with horizontal beams (issue 337560043 by address@hidden) |
|
Date: |
Sat, 10 Feb 2018 05:26:34 -0800 |
LGTM, though I have a couple of observations.
https://codereview.appspot.com/337560043/diff/1/lily/beam-quanting.cc
File lily/beam-quanting.cc (right):
https://codereview.appspot.com/337560043/diff/1/lily/beam-quanting.cc#newcode717
lily/beam-quanting.cc:717: if ((concaveness >= 10000) || (damping >=
10000))
If I interpret this correctly, you're trying to avoid a later division
when the divisor is large. That divisor is (concaveness + damping), so
perhaps this should be (concaveness + damping) >= threshold.
https://codereview.appspot.com/337560043/diff/1/lily/beam-quanting.cc#newcode730
lily/beam-quanting.cc:730: slope = 0.6 * tanh (slope) / (damping +
concaveness);
Pre-existing issue: division by zero if damping = -concaveness. (Not
saying you have to fix it, but you might want to if you are making other
changes.)
https://codereview.appspot.com/337560043/