lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Avoid duplicate rehearsal marks in regression tests (issue 334510043 by


From: nine . fierce . ballads
Subject: Avoid duplicate rehearsal marks in regression tests (issue 334510043 by address@hidden)
Date: Sun, 18 Feb 2018 05:51:40 -0800

Reviewers: Malte Meyn,

Message:
Malte,
This patch changes a regression test you committed in January.  I think
it still covers what you intended to cover.


Description:
Avoid duplicate rehearsal marks in regression tests

Having multiple marks with the same sequence number is something that
LilyPond might reasonably warn about in a future version.

I suppose LilyPond might reasonably warn about out-of-sequence marks,
but I haven't gone that far with this.  Let me know if you think I
should.

Please review this at https://codereview.appspot.com/334510043/

Affected files (+12, -12 lines):
  M input/regression/rehearsal-mark-formatters.ly


Index: input/regression/rehearsal-mark-formatters.ly
diff --git a/input/regression/rehearsal-mark-formatters.ly b/input/regression/rehearsal-mark-formatters.ly index 7dc06d850e8cd75dd72f6de8551520ab0beb515e..89695a64fd3f472da5b1fc089ff1f68677e7c5ca 100644
--- a/input/regression/rehearsal-mark-formatters.ly
+++ b/input/regression/rehearsal-mark-formatters.ly
@@ -4,20 +4,20 @@
   texidoc = "
 Comparison of markFormatter functions.

-The marks should read H, J, H, K, I, K, 94, XCIV, 9, AB, BB, Bb, xciv,
-boxed A, circled A, ovalled A, medium font A.
+The marks should read H, K, I, K, 93, XCIV, 9, AB, CC, Dd, xcvi,
+boxed A, circled B, ovalled C, medium font D.
 "
 }

 {
-  % default: #format-mark-letters (omit I)
-  \mark 8 R1 \mark 9 R
+  %% Regression test rehearsal-mark-letter covers the default
+  %% format-mark-letters (omit I)
   \set Score.markFormatter = #format-mark-alphabet
-  \mark 8 R \mark 11 R
+  \mark 8 R1 \mark 11 R
   \set Score.markFormatter = #(format-mark-generic '(alphabet-omit-j))
   \mark 9 R \mark 10 R
   \set Score.markFormatter = #format-mark-numbers
-  \mark 94 R
+  \mark 93 R
   \set Score.markFormatter = #(format-mark-generic '(roman))
   \mark 94 R
   \set Score.markFormatter = #format-mark-barnumbers
@@ -26,17 +26,17 @@ boxed A, circled A, ovalled A, medium font A.
   \set Score.markFormatter = #(format-mark-generic '())
   \mark 27 R
   \set Score.markFormatter = #(format-mark-generic '(repeat))
-  \mark 27 R
+  \mark 28 R
   \set Score.markFormatter = #(format-mark-generic '(repeat mixedcase))
-  \mark 27 R
+  \mark 29 R
   \set Score.markFormatter = #(format-mark-generic '(roman lowercase))
-  \mark 94 R
+  \mark 96 R
   \set Score.markFormatter = #format-mark-box-alphabet
   \mark 1 R
   \set Score.markFormatter = #format-mark-circle-alphabet
-  \mark 1 R
+  \mark 2 R
   \set Score.markFormatter = #(format-mark-generic '(oval))
-  \mark 1 R
+  \mark 3 R
   \set Score.markFormatter = #(format-mark-generic '(medium))
-  \mark 1 R
+  \mark 4 R
 }





reply via email to

[Prev in Thread] Current Thread [Next in Thread]