[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5284: improve ASSIGN_EVENT_ONCE (issue 338540043 by address@hi
|
From: |
dak |
|
Subject: |
Re: Issue 5284: improve ASSIGN_EVENT_ONCE (issue 338540043 by address@hidden) |
|
Date: |
Sun, 04 Mar 2018 14:08:51 -0800 |
https://codereview.appspot.com/338540043/diff/1/lily/include/stream-event.hh
File lily/include/stream-event.hh (right):
https://codereview.appspot.com/338540043/diff/1/lily/include/stream-event.hh#newcode51
lily/include/stream-event.hh:51: extern void
Using "extern" for function prototypes is weird. It's not done
elsewhere in the LilyPond code base as far as I can tell (except for
internal_event_assignment which is likely a mistake as well).
https://codereview.appspot.com/338540043/diff/1/lily/stream-event.cc
File lily/stream-event.cc (right):
https://codereview.appspot.com/338540043/diff/1/lily/stream-event.cc#newcode133
lily/stream-event.cc:133: if (0 == nc.compare(nc.size() - suffix.size(),
suffix.size(), suffix))
if nc is shorter than 6 chars anyway, this will crash.
https://codereview.appspot.com/338540043/