[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5284: improve ASSIGN_EVENT_ONCE (issue 338540043 by address@hi
|
From: |
Carl . D . Sorensen |
|
Subject: |
Re: Issue 5284: improve ASSIGN_EVENT_ONCE (issue 338540043 by address@hidden) |
|
Date: |
Wed, 07 Mar 2018 08:51:51 -0800 |
I haven't tested the functionality, but I noticed that the warning
messages were not consistent with the LilyPond guidelines on
localization.
https://codereview.appspot.com/338540043/diff/20001/lily/stream-event.cc
File lily/stream-event.cc (right):
https://codereview.appspot.com/338540043/diff/20001/lily/stream-event.cc#newcode146
lily/stream-event.cc:146: oc.c_str ()));
According to CG 10.5.8 Localization it would probably be better to write
the warnings like this:
("conflict with event : `%s'", oc.c_str ())
("discarding event: `%s'", nc.c_str ())
https://codereview.appspot.com/338540043/