[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Avoid failed assertion in stem tremolo code (issue 572550043 by addr
From: |
k-ohara5a5a |
Subject: |
Re: Avoid failed assertion in stem tremolo code (issue 572550043 by address@hidden) |
Date: |
Wed, 03 Apr 2019 10:10:50 -0700 |
https://codereview.appspot.com/572550043/diff/560590043/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (left):
https://codereview.appspot.com/572550043/diff/560590043/lily/stem-tremolo.cc#oldcode175
lily/stem-tremolo.cc:175: Interval ph = stem->pure_y_extent (stem, 0,
INT_MAX);
My suggested change to return s1.extent will probably cause
green-highlights in the regression tests, because the highlighting
function compares the numerical /extents/ of the graphical objects. If
the spacing of the black-printed glyphs remains good, everything should
be fine.
https://codereview.appspot.com/572550043/