Re: interrupted notes

[Han-Wen Nienhuys]

address@hidden writes:
> Michael Welsh Duggan <address@hidden> writes:
> And here is the patch:
> 
> Index: lily/audio-staff.cc
> ===================================================================
> RCS file: /cvsroot/lilypond/lilypond/lily/audio-staff.cc,v
> retrieving revision 1.19
> diff -u -p -u -p -r1.19 audio-staff.cc
> --- lily/audio-staff.cc       5 Feb 2004 14:55:17 -0000       1.19
> +++ lily/audio-staff.cc       20 Apr 2004 03:46:51 -0000
> @@ -12,6 +12,17 @@
>  #include "midi-stream.hh"
>  #include "midi-walker.hh"
>  
> +Audio_staff::Audio_staff (const Performer *performer)
> +{
> +  performer_ = performer;
> +}
> +
> +SCM
> +Audio_staff::internal_get_property (SCM sym) const
> +{
> +  return performer_->internal_get_property (sym);
> +}
> +

This is a no-no. performer_ is a garbage collected Scheme object,
which means that this statement will randomly dump core. Besides,
audio-items don't have Scheme properties, and this makes the wrong
impression that they do.

Just store what you need to store in the C++ object.

Anyway, it's great to have someone look at the MIDI part. Can you try
again, taking my remarks into account? 


-- 

 Han-Wen Nienhuys   |   address@hidden   |   http://www.xs4all.nl/~hanwen