Re: default midi velocity

[Neil Puttock]

2009/4/7 Martin Tarenskeen <address@hidden>:
> On Mon, Apr 06, 2009 at 09:50:17AM +0200, Martin Tarenskeen wrote:
>>
>> Patch attached for those who want to try.
>>
>
> I was wondering what the "experts" think of my suggested patches to
> change Lilypond's MID output behaviour:
>
> Current: default MIDI Note On velocity value of 127
> Proposed: default MIDI Note On velocity value of 90
>
> Current: default MIDI Note Off velocity value of 64
> Proposed: MIDI Note On message with velocity=0 used as (pseudo-) Note
> Off message. This is the normal method in the MIDI world.

I'm no midi expert, but your changes look (and sound) fine to me.

Some suggestions for your patch:

+  // dynamic_byte_ = 0x7f;

You can remove this.


@@ -229,13 +230,14 @@
   //  0 should definitely be avoided, notes stick on some sound cards.
   // 64 is supposed to be neutral

These comments should also be removed.

+  // proposed patch: use note_on with velocity=0 instead of note_off

Remove `proposed patch:'

 string
 Midi_note_off::to_string () const
 {
-  Byte status_byte = (char) (0x80 + channel_);
+  Byte status_byte = (char) (0x90 + channel_); //use note_on velocity=0

I don't think a comment's necessary here if it's mentioned above.

Do you have git installed?  It would be preferable to have a patch
created with git format-patch.

Regards,
Neil