Re: thanks again for the editionEngraver

[Janek Warchoł]

Hi,

2014-07-30 20:39 GMT+02:00 Janek Warchoł <address@hidden>:
> Hi,
>
> 2014-07-30 0:54 GMT+02:00 David Kastrup <address@hidden>:
>> Janek Warchoł <address@hidden> writes:
>>> As i said, defining new instrument contexts is very cheap - you can just do
>>>
>>> \newInstrument "ViolinI" "Violin" "StaffGroup"\with { } \with { }
>>> \newInstrument "ViolinII" "Violin" "StaffGroup"\with { } \with { }
>>>
>>> and have ViolinI and ViolinII available.
>>
>> Would it be feasible to put the context mods _before_ some reasonably
>> related argument, possibly like
>>
>> \newInstrument \with {} "ViolinI" "Violin" \with {} "StaffGroup"
>>
>> or probably
>>
>> \newInstrument "Violin" \with {} "ViolinI" \with {} "StaffGroup" ?
>>
>> Because when they are before a related non-optional argument, one can
>> make them optional.  Then if they are just \with {} anyway, you can omit
>> them.
>
> Good idea!  I'm fine with changing the order of the arguments; the
> function is still in the experimental phase and there's not much code
> depending on it.

Done!  The syntax is now

    \newInstrument name staff-settings voice-settings parent-name

with staff-settings and voice-settings being optional.  With these
changes, defining "ViolinI" instrument (assuming we already have a
"Violin" instrument) is simply

    \newInstrument ViolinI Violin

and this ROCKS! :D

View the code at
https://github.com/openlilylib/openlilylib/tree/master/templates/predefined-instruments

thanks for suggestions, and i hope this will be helpful for Jan-Peter's work!
Janek