Re: (Git users) Please test a Fresocbaldi Feature

[Federico Bruni]

Il giorno ven 17 mar 2017 alle 9:06, Urs Liska <address@hidden> ha 
scritto:
> Hi all,
>
> there's a pull request for Frescobaldi, submitted by a new 
> contributor (https://github.com/wbsoft/frescobaldi/pull/905), and I 
> have a problem with it: The contributor states it works for him, I 
> can't see anything wrong in the code, but it doesn't work for me. So 
> I'd be happy if others could give it a try to see if we've missed 
> something in the code or if it's an issue with my set-up.
>
> Steps to do so:
>
> Be sure that you run Frescobaldi from its Git repository
> Add https://github.com/prabhanshuguptagit/frescobaldi.git as a remote
> Pull from that remote
> checkout the midiinput_addshortcut branch from that remote
> (Re-)Start Frescobaldi
> Open the MIDI Input tool
> Try Ctrl+Shift+3
> This should toggle the "Accidentals" radio button between sharps and 
> flats and so improve the handling when using MIDI input.
Hi Urs

It works for me: it toggles between sharps and flats. I'll add a 
comment on the pull request.

My computer is running:

Frescobaldi: 3.0.0
Python: 3.5.3
python-ly: 0.9.4
Qt: 5.7.1
PyQt: 5.7
sip: 4.18.1
poppler: 0.45.0
python-poppler-qt: 0.24.2
OS: Linux-4.9.13-201.fc25.x86_64-x86_64-with-fedora-25-Twenty_Five


Let me add that you can test a github PR without adding the remote.
In this case I did:

git fetch origin pull/905/head:midiinput_addshortcut
>
git checkout midiinput_addshortcut