Re: fretboard-bug?

[Thomas Morley]

2017-09-28 13:50 GMT+02:00 Malte Meyn <address@hidden>:
>
>
> Am 28.09.2017 um 13:08 schrieb bb:
>>
>>                          #"1-1; 1-1;o;o;2-2;" %
>
>
> This is not a bug but you have an extra space here. It should be
>
> #"1-1;1-1;o;o;2-2;" % correct
> #"1-1; 1-1;o;o;2-2;" % wrong but not a bug



commit e2e1656c9d0897fb45a215bdcb96b146100c33e2
Author: Thomas Morley <address@hidden>
Date:   Sun Aug 23 15:24:06 2015 +0200

    Clear fret-diagram- and harp-pedal-input-strings from whitespace

    issue 4575

    Whitespace-characters are deleted before further processing.

    Allows for
    \markup \fret-diagram #"s:2;h:5;
    6-3;5-5;4-5;3-4;2-3;1-x;"

    Also adding errors for typos in fret-diagram with a meaningful message:
    \markup \fret-diagram #"s:2;g:r;
    6-3;5-5;4-5;3-4;2-3;1-x;"
    will return:
    fatal error: Unhandled entry in fret-diagram "g:r" in "g:r"

    This error would not apply, if something for #\g would be defined
    in fret-parse-definition-string somewhere in the future.

    Then, the message would be:
    fatal error: Unhandled entry in fret-diagram "r" in "g:r"

    Something similiar is already in harp-pedals.scm


was meant to remove unwanted white-space from input-strings for markup-commands.

5204 Remove white-space from storePredefinedDiagram input-string
https://sourceforge.net/p/testlilyissues/issues/5204/

now does the same for storePredefinedDiagram.


Cheers,
  Harm