[Linphone-developers] Bug in RTCP APP and BYE handling code (oRTP lib)

[Dmitry Sobinov]

Hi everyone.

I've found bug in oRTP library. Some code in rtcpparse.c that works with APP and BYE packet types

does not correctly calculates data lengths using rtcp_common_header_get_length(). For example:

int datalen=sizeof(rtcp_common_header_t)+rtcp_common_header_get_length(&app->ch)-8;

Result of rtcp_common_header_get_length() should be multiplied by 4 to get size in bytes,

but it seems someone forgot to fix this in some places.

I've attached the patch.

Regards,

Dmitry Sobinov

ortp.patch
Description: Binary data