linterna-magica-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linterna-magica-commit] [166] Removing unsused string template.


From: Ivaylo Valkov
Subject: [linterna-magica-commit] [166] Removing unsused string template.
Date: Fri, 29 Jul 2011 07:25:49 +0000

Revision: 166
          
http://svn.sv.gnu.org/viewvc/?view=rev&root=linterna-magica&revision=166
Author:   valkov
Date:     2011-07-29 07:25:48 +0000 (Fri, 29 Jul 2011)
Log Message:
-----------
Removing unsused string template. The replacement object is now properly 
marked, so it is not processed after insertion.

Modified Paths:
--------------
    trunk/src/lm_create_video_object.js
    trunk/src/lm_video_and_flash_objects_helper_functions.js

Modified: trunk/src/lm_create_video_object.js
===================================================================
--- trunk/src/lm_create_video_object.js 2011-07-28 14:10:48 UTC (rev 165)
+++ trunk/src/lm_create_video_object.js 2011-07-29 07:25:48 UTC (rev 166)
@@ -302,8 +302,13 @@
                                "important");
     container.appendChild(about_box);
     
-    object_tag.setAttribute("class", 
-                           this.marked_object_template+"video-"+id);
+    // Mark the object, so it is not processed and chacked after
+    // insertion. The function mark_flash_object will use new id and
+    // that might not be a good idea (object count, XHRs, duplicate
+    // objects ... ). The linterna_magica_id property is set ot a
+    // float, so it is not the same as the one of the flash object.
+    object_tag.linterna_magica_id = parseFloat(object_data.linterna_magica_id+
+                                              
"."+object_data.linterna_magica_id);
 
     // Add link after the object/embed
     // this.set_priority() has set this.priority

Modified: trunk/src/lm_video_and_flash_objects_helper_functions.js
===================================================================
--- trunk/src/lm_video_and_flash_objects_helper_functions.js    2011-07-28 
14:10:48 UTC (rev 165)
+++ trunk/src/lm_video_and_flash_objects_helper_functions.js    2011-07-29 
07:25:48 UTC (rev 166)
@@ -26,11 +26,6 @@
 
 // END OF LICENSE HEADER
 
-// Used for class names of marked objects. Flash objects might have
-// id's already. It is not a good idea to replace them.
-LinternaMagica.prototype.marked_object_template =
-    "linterna-magica-processed-object-";
-
 // Increment the counter for found video flash objects, mark the
 // element with appropriate class attribute and return the new value.
 LinternaMagica.prototype.mark_flash_object = function(element)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]