[lmi-commits] [5317] Move and update certain documentation

[Greg Chicares]

Revision: 5317
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=5317
Author:   chicares
Date:     2011-11-29 15:24:22 +0000 (Tue, 29 Nov 2011)
Log Message:
-----------
Move and update certain documentation

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/ihs_acctval.cpp
    lmi/trunk/ihs_irc7702a.hpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2011-11-29 15:11:20 UTC (rev 5316)
+++ lmi/trunk/ChangeLog 2011-11-29 15:24:22 UTC (rev 5317)
@@ -28676,3 +28676,25 @@
   version.hpp
 Designate release candidate.
 
+20111128T1214Z <address@hidden> [606]
+
+  ihs_acctval.cpp
+Distinguish target from minimum no-lapse premium.
+
+20111129T1207Z <address@hidden> [606]
+
+  ihs_acctval.cpp
+  ihs_irc7702.cpp
+Move and update certain documentation.
+
+20111129T1511Z <address@hidden> [606]
+
+  ihs_acctval.cpp
+Improve documentation, describing some planned changes.
+
+20111129T1524Z <address@hidden> [605]
+
+  ihs_acctval.cpp
+  ihs_irc7702a.hpp
+Move and update certain documentation.
+

Modified: lmi/trunk/ihs_acctval.cpp
===================================================================
--- lmi/trunk/ihs_acctval.cpp   2011-11-29 15:11:20 UTC (rev 5316)
+++ lmi/trunk/ihs_acctval.cpp   2011-11-29 15:24:22 UTC (rev 5317)
@@ -454,10 +454,6 @@
 // The following two comment blocks will soon be expunged.
 //  - Irc7702_ and Irc7702A_ are appropriately initialized together
 //    here, soon after PerformSpecAmtStrategy() is called.
-//  - GLP and GSP seem to be correct when specamt is determined by a
-//    strategy or a solve.
-//  - Perhaps the 7702A class should have accessors like RoundedGLP();
-//    that would better be noted in that class.
 
     // TODO ?? We need to reconsider where the Irc7702 object gets created.
     // Perhaps it should be when initial DB is first known? No, needed for
@@ -474,16 +470,8 @@
         ,annual_target_premium
         );
 
-    // JOE--Try this instead of your second change to ldginvar.cpp
-    // and particularly your change to basicval.hpp . It is always better
-    // to add a const accessor than to publish a private member. Besides,
-    // this avoids recalculating GLP and GSP. And does your code calculate
-    // guideline premiums correctly if specified amount is determined by
-    // a strategy or a solve?
     InvariantValues().InitGLP = Irc7702_->RoundedGLP();
     InvariantValues().InitGSP = Irc7702_->RoundedGSP();
-    // TODO ?? JOE--If you accept this modification, would you do the same sort
-    // of thing for the initial seven-pay premium as well please?
 
     // This is notionally called once per *current*-basis run
     // and actually called once per run, with calculations suppressed

Modified: lmi/trunk/ihs_irc7702a.hpp
===================================================================
--- lmi/trunk/ihs_irc7702a.hpp  2011-11-29 15:11:20 UTC (rev 5316)
+++ lmi/trunk/ihs_irc7702a.hpp  2011-11-29 15:24:22 UTC (rev 5317)
@@ -157,6 +157,8 @@
         ,double a_LoadExcess
         ,double a_CashValue
         ) const;
+    // SOMEDAY !! Consider using accessors like Irc7702::RoundedGLP()
+    // to encapsulate rounding within this class.
     double GetPresent7pp() const        {return SevenPP;}
     bool IsMecAlready() const           {return IsMec;}